Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No Merge] Added command to unlock annex repo to restore files from symbolic links. #1559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikhilchandra
Copy link

fixes #1550

I did a little digging and I think the problems with downloaded files being replaced with 1KB symbolic links has to do with the way annex repositories work. I added an "unlock" command after the forced checkout and it seems to fix the issue on my Windows computer.

@zm711
Copy link
Contributor

zm711 commented Sep 18, 2024

It looks to me like this doesn't break the linux based CI. I'll leave this open for a little bit to see if anyone else has feelings about this, but I'm okay with it.

Also @nikhilchandra you don't show up as having ever contributed code. Is that intentional (ie you did a github setting) is it a github bug?

@nikhilchandra
Copy link
Author

nikhilchandra commented Sep 18, 2024

@zm711 If you don't mind, I would prefer to not merge this pull request. It worked yesterday on my machine for test_plexon2rawio.py but I just ran pytest again from the root directory and there are a lot of breaks. I would like to hold off until there is a better understanding of what's going on. Is it possible to just mark the PR as put on hold for later consideration?

I have not been very active on github until recently. I used Bitbucket in grad school and since my projects were solo everything was in private repos.

@zm711
Copy link
Contributor

zm711 commented Sep 18, 2024

Yeah, I'll mark as request changes which lets the team know not to merge.

I was mainly asking to make sure you got credit for your contributions unless you had some setting for privacy. This seems like a github bug in that it is is saying that you haven't contributed anything to the repo. Seems weird, but who knows.

Copy link
Contributor

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more local testing. Do not merge.

@zm711 zm711 changed the title Added command to unlock annex repo to restore files from symbolic links. [No Merge] Added command to unlock annex repo to restore files from symbolic links. Sep 18, 2024
@nikhilchandra
Copy link
Author

@zm711 Is there a more private mechanism for communicating over github?

@zm711
Copy link
Contributor

zm711 commented Sep 18, 2024

Not that I know of. You can use my throw away email if needed mineurs-torrent0x [at] icloud.com

@zm711 zm711 added this to the future milestone Oct 11, 2024
@zm711
Copy link
Contributor

zm711 commented Oct 11, 2024

@JuliaSprenger could you comment on this please?

@zm711
Copy link
Contributor

zm711 commented Oct 12, 2024

Hey @nikhilchandra we've discussed this a bit more and we agree with the git-annex and datalad documentation that basically we don't know if this will ever really work with Windows so the preferred for this testing is to use Mac/Linux. You could try to mimic what @h-mayorquin has done in the spikeinterface ci to get windows to work for some stuff. We can wait to see if @JuliaSprenger has any opinions on this, but we will likely close this if she doesn't feel strongly about this.

@nikhilchandra
Copy link
Author

Gotcha. It was worth a try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseTestRawIO's setUp function deletes data needed for subsequent tests--on windows
2 participants