-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No Merge] Added command to unlock annex repo to restore files from symbolic links. #1559
base: master
Are you sure you want to change the base?
Conversation
It looks to me like this doesn't break the linux based CI. I'll leave this open for a little bit to see if anyone else has feelings about this, but I'm okay with it. Also @nikhilchandra you don't show up as having ever contributed code. Is that intentional (ie you did a github setting) is it a github bug? |
@zm711 If you don't mind, I would prefer to not merge this pull request. It worked yesterday on my machine for test_plexon2rawio.py but I just ran pytest again from the root directory and there are a lot of breaks. I would like to hold off until there is a better understanding of what's going on. Is it possible to just mark the PR as put on hold for later consideration? I have not been very active on github until recently. I used Bitbucket in grad school and since my projects were solo everything was in private repos. |
Yeah, I'll mark as I was mainly asking to make sure you got credit for your contributions unless you had some setting for privacy. This seems like a github bug in that it is is saying that you haven't contributed anything to the repo. Seems weird, but who knows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need more local testing. Do not merge.
@zm711 Is there a more private mechanism for communicating over github? |
Not that I know of. You can use my throw away email if needed mineurs-torrent0x [at] icloud.com |
@JuliaSprenger could you comment on this please? |
Hey @nikhilchandra we've discussed this a bit more and we agree with the git-annex and datalad documentation that basically we don't know if this will ever really work with Windows so the preferred for this testing is to use Mac/Linux. You could try to mimic what @h-mayorquin has done in the spikeinterface ci to get windows to work for some stuff. We can wait to see if @JuliaSprenger has any opinions on this, but we will likely close this if she doesn't feel strongly about this. |
Gotcha. It was worth a try :) |
fixes #1550
I did a little digging and I think the problems with downloaded files being replaced with 1KB symbolic links has to do with the way annex repositories work. I added an "unlock" command after the forced checkout and it seems to fix the issue on my Windows computer.