Issues #125, 129, and 140 #169
Conversation
|
I'll need to update read me file with changes. Can you also tag this as a 1.1 version please in the code? |
|
did you want to wait for the rest of the issues to be resolved? (fixing sync, customizing login page, etc) |
I think so. You can keep doing to this draft PR. And I can test against it before merging. |
|
This branch is named specific to the issues that were fixed so I made a 1.1 branch and set that as the upstream for this one |
src/admin-settings.php
Outdated
| } elseif ($wild_apricot_url) { | ||
| } elseif ($api_status == WA_Integration::API_STATUS_INCORRECT_SCOPE) { | ||
| // incorrect scope selected | ||
| echo '<p class="wap-error">Incorrect application scope. Please create a <strong>full-access Server Application</strong> on Wild Apricot.</p>'; |
There was a problem hiding this comment.
WildApricot is the correct spelling
Ok, this pull is set to go against master so you probably want to change the target to 1.1 |
reference the 1.1 branch
reference 1.1 branch correctly
|
@nataliebrotherton please confirm the changes I requested and make the edits. |
Issue #125 turn on debug log by default
Issue #129 Validate correct authorized application
Issue #140 Remove admin-only fields
disabledor grayed out checkboxes