Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laxer control on checking authorized WA UL for licensing #158

Open
asirota opened this issue Sep 13, 2024 · 2 comments · Fixed by #167
Open

laxer control on checking authorized WA UL for licensing #158

asirota opened this issue Sep 13, 2024 · 2 comments · Fixed by #167
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@asirota
Copy link
Member

asirota commented Sep 13, 2024

when checking the license key authorized URL let's use this more lax control to check the domain

if the TLD is wildapricot.org

  • eliminate the http(s) checking and just check the full domain name with the subdomain for equality being case insensitive

so

http://text.wildapricot.org from license key should match https://text.wildapricot.org as the primary domain name from the API
http://text.wildapricot.org from license key will NOT match https://text123.wildapricot.org as the primary domain name from the API

  • for all other domains

eliminate http(s) from the evaluation

and evaluate the top level domain only for being valid

so https://www.mydomain.org in the license key will validate http://mydomain.org

or

http://mydomain.org in the license key will validate https://www.mydomain.org

or

https://mydomain.org in the license key will validate http://somesubdomain.mydomain.org

@asirota asirota added the enhancement New feature or request label Sep 13, 2024
@asirota asirota added this to the 1.0.3 milestone Sep 13, 2024
@nataliebrotherton
Copy link
Collaborator

@asirota is this resolved?

@asirota
Copy link
Member Author

asirota commented Oct 8, 2024

I have to do some testing, but last time I looked I think it was ok.

@nataliebrotherton nataliebrotherton linked a pull request Oct 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants