Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Consecutive LineStrings aren't being combined #151

Open
nrankin18 opened this issue Jul 11, 2023 · 3 comments
Open

[BUG] - Consecutive LineStrings aren't being combined #151

nrankin18 opened this issue Jul 11, 2023 · 3 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@nrankin18
Copy link

Describe the bug
See ZKC's map attached below, which has only two point LineStrings

To Reproduce
Steps to reproduce the behavior:
1.
2.
3.
4.

Expected behavior

Screenshots
If applicable, add screenshots to help explain your problem.

@nrankin18 nrankin18 added the bug Something isn't working label Jul 11, 2023
@nrankin18
Copy link
Author

@KSanders7070
Copy link
Collaborator

KSanders7070 commented Aug 11, 2023

Upon initial review, it LOOKS like the facility has reversed Beginning/Ending LAT/LON values however to be sure, we need the .GeoMap for ZKC and their files are protected behind their website login. Message sent to the ZKC DATM Chris Raabe on 10AUG2023 and awaiting response.

Nikolai558 added a commit that referenced this issue Aug 12, 2023
#151 - Sounds like the source file coords are reversed. just from looking at the output file from FE buddy. I would need the source file before I am comfortable writing code to fix this issue.

Additional comments to prepare for adding defaults to the geojson output.
@Nikolai558 Nikolai558 added the wontfix This will not be worked on label Aug 12, 2023
@KSanders7070
Copy link
Collaborator

I took a look at your vERAM files and I see why they are so bulky… they have a reversed “flow” of coordinates from normal.

If a line string goes from point 1 to 2 to 3 and to 4…. They normally draw it like this in the file:
1-2… 2-3… 3-4
but ZKCs does this a significant amount of the time:
2-1… 3-2… 4-3

FE-Buddy thinks that since the starting coordinate does not match the previous ending coordinate, that you want to BREAK the line here and begin a new one. With GeoJSONs, this means making a completely new Feature and will result in EVERY line having its own feature. This creates massive GeoJSON files.

Though, we are brainstorming ideas for how to resolve this with FE-Buddy, it is unlikely to happen, at least anytime soon so, if ZKC are having problems with bulky GeoJSONs, they may need to consider finding a way reformat it to: 1-2… 2-3… 3-4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants