Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - vERAM-GeoJSON "Input String" error #159

Open
KSanders7070 opened this issue Sep 12, 2023 · 1 comment · Fixed by #160
Open

[BUG] - vERAM-GeoJSON "Input String" error #159

KSanders7070 opened this issue Sep 12, 2023 · 1 comment · Fixed by #160
Assignees
@Nikolai558
Labels
Completed

Comments

@KSanders7070
Copy link
Collaborator

image
ZDV GeoMaps.zip
@KSanders7070 KSanders7070 added the bug Something isn't working label Sep 12, 2023
@KSanders7070 KSanders7070 changed the title [BUG] - ZDV vERAM-GeoJSON "Input String" error [BUG] - vERAM-GeoJSON "Input String" error Sep 12, 2023
Nikolai558 added a commit that referenced this issue Sep 12, 2023
@Nikolai558
#159 - Problem with Filters = ""
135732b 
This fixes the problem when Filters = "", however, currently it will place filters = [] in the geojson.
Not sure how CRC Will handle a default that does not have any filters in it.
@Nikolai558
Copy link
Owner

The problem FE-Buddy was having with "ZAB" was that they had some defaults that equaled just an empty string. See Picture Below
image

Initial fix was to just handle for empty strings which placed empty filters in the geojson, see picture below
image

I did impliment another fix that looks at the BCG. As long as the defaults have a valid BCG the filters will be set to the same value, see picture below.
image

@Nikolai558 Nikolai558 added Completed and removed bug Something isn't working labels Sep 12, 2023
@Nikolai558 Nikolai558 linked a pull request Sep 12, 2023 that will close this issue
Releasing 2.6.8 #160
Merged
Nikolai558 added a commit that referenced this issue Sep 12, 2023
@Nikolai558
#159 - Filters = "" issue
51dfa9d 
I am going to recant my previous statement and will not be placing the filter value based on BCG values.

The reasoning behind this is there might be quite a few facilities where the BCG value is not supose to match the filter value. Also, in vERAM things that do not have a filter at all are not displayed (same thing happens in CRC). If I were to automatically place the bcg into the filter in the geojson, these facilities would have a bunch of things populate on screen that were never there before.

I personally don't know of a valid reason to set filters="" but I do know that some facilities do it.

Therefore, FEB will create the defaults in geojson with filters = [] and a message will be placed in the log so that users can quickly find what default filters dont have any filters in it. Then they can choose weather or not they want to add filters manually in the geojson. This result should be the same in CRC as it is in vERAM. (i.e. no filters = no display)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikolai558 Nikolai558

Labels
Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Releasing 2.6.8 Nikolai558/FE-BUDDY
2 participants
@Nikolai558 @KSanders7070