Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "ecmaVersion": 8 from .eslintrc.json? #50

Open
NilsEnevoldsen opened this issue Apr 13, 2020 · 1 comment
Open

Remove "ecmaVersion": 8 from .eslintrc.json? #50

NilsEnevoldsen opened this issue Apr 13, 2020 · 1 comment
Labels

Comments

@NilsEnevoldsen
Copy link
Owner

I think this extension isn't supposed to use features beyond ES3 in order to be compatible with ResourceLoader. https://phabricator.wikimedia.org/T75714

"parserOptions": {
"ecmaVersion": 8
}

I used a higher version because I didn't know better and it appears to work. I'm going to wontfix this issue, but keep it open for informational purposes, or in case some contributor is ambitious.

@Aspallar
Copy link
Contributor

I would agree with the wontfix - the ES3 limitation appears to only apply to js in a wiki's Common.js and in users personal js pages. So the only reason to re-code to ES3 would be to support Internet Explorer 11, a dying browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants