jar squishing, part 8 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
less constructors = smaller lol
[skip ci]
[skip ci]
[skip ci]
java 21 moment
definitely larger but at least get() works now
yes
# Conflicts: # modern/src/main/java/dev/nolij/zume/mixin/modern/MouseHandlerMixin.java
[skip ci]; doesn't work because zson isn't in mavenlocal on github runners
least cursed zume code ive written
but is larger :( and other stuff idk
Nolij
requested changes
May 17, 2024
api/src/main/java/dev/nolij/zume/impl/config/ZumeConfigImpl.java
Outdated
Show resolved
Hide resolved
api/src/main/java/dev/nolij/zume/impl/config/ZumeConfigImpl.java
Outdated
Show resolved
Hide resolved
archaic/src/main/java/dev/nolij/zume/mixin/archaic/EntityRendererMixin.java
Show resolved
Hide resolved
# Conflicts: # lexforge/build.gradle.kts # neoforge/build.gradle.kts
Nolij
requested changes
May 20, 2024
# Conflicts: # proguard.pro
broken because jvmdg
|
DCO Assistant Lite bot All contributors have read and affirmed the entire contents of the Developer Certificate of Origin. |
|
I have read and hereby affirm the entire contents of the Developer Certificate of Origin. |
…attributes in source files
just need the providers also not tested
|
Please wait for my review on the reformat before merging. I've found some changes the IntelliJ formatter makes are ones I disagree with and theres no way to change them in |
Nolij
previously requested changes
May 31, 2024
api/src/main/java/dev/nolij/zume/api/platform/v1/IZumeImplementation.java
Outdated
Show resolved
Hide resolved
api/src/main/java/dev/nolij/zume/api/util/v1/MethodHandleHelper.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/kotlin/dev/nolij/zumegradle/JarCompressing.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/kotlin/dev/nolij/zumegradle/JarCompressing.kt
Outdated
Show resolved
Hide resolved
This reverts commit a92261e
|
Sorry for wasting your reviewing time but I just reverted that commit |
embeddedt
approved these changes
Jun 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zume.mixin(optional)