Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In ocn_comp_nuocp.F90, the prefix !$omp <something openmp> is used in a non-standard way. #379

Open
mvertens opened this issue Aug 20, 2024 · 1 comment · May be fixed by #422
Open

In ocn_comp_nuocp.F90, the prefix !$omp <something openmp> is used in a non-standard way. #379

mvertens opened this issue Aug 20, 2024 · 1 comment · May be fixed by #422

Comments

@mvertens
Copy link
Contributor 

          For all other OMP calls, the prefix `!$omp <something openmp>` is used. I find it strange that this is not required here. Is this documented somewhere?

Originally posted by @TomasTorsvik in #377 (comment)
@mvertens mvertens changed the title For all other OMP calls, the prefix !$omp <something openmp> is used. I find it strange that this is not required here. Is this documented somewhere? In ocn_comp_nuocp.F90, the prefix !$omp <something openmp> is used in a non-standard way. Aug 20, 2024
@TomasTorsvik
Copy link
Contributor

TomasTorsvik commented Aug 20, 2024 •
edited
Loading

There are 1505 instances of !$in the master code, 1504 continues !$omp and a single instance without this continuation.

The odd one out is ocn_comp_nuopc.F90; L404.

!$    call omp_set_num_threads(nthrds)

@TomasTorsvik TomasTorsvik linked a pull request Oct 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant OMP call TomasTorsvik/BLOM-TTfork
2 participants
@mvertens @TomasTorsvik