-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
insert
taking a &mut Connection
instead of an impl Executor
#22
Comments
Hey! Lovely to hear that it's usefull to you! |
I guess we could have different |
Oh that is interesting and it does make sense. I suppose it's only a small annoyance I can easily live with for now. Thank you for that swift answer 🙏 |
Wouldn't it be possible to run the START TRANSACTION;
INSERT INTO {} ({)) VALUES ({});
SELECT LAST_INSERT_ID() AS id;
COMMIT; |
Fixed in #40. Now the MariaDB backend also uses a form of |
sqlx 0.7 sadly changed the API of |
Hello!
I started experimenting with this crate and so far, I love it!
There is one thing that I'm curious about though:
All methods on
Table
take adb: impl Executor<...>
argument except forinsert
that takes adb: &mut <Db as Database>::Connection
.Is there any reason for that? I find it quite annoying to be able to simply pass my
&PgPool
anywhere except forinsert
where I need to&mut pool.acquire().await?
.The text was updated successfully, but these errors were encountered: