Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

[BUG] get_dependencies stops on first uninstallable module within a given addons folder #420

Closed
blaggacao opened this issue Jan 15, 2017 · 1 comment

Comments

@blaggacao
Copy link

Just have a look: (take into account, that "uninstallable" means 'installable != True` in the manifest)

        for path in addons_path.split(','):
            manif_path = is_installable_module(   # This returns false if not installable
                os.path.join(path, addons_list[0]))
            if not manif_path:   # This breakes the recursion if not installable
                continue
            manif = eval(open(manif_path).read())
            return list(
                set(manif.get('depends', [])) |
                set(get_test_dependencies(addons_path, addons_list[1:])) -  # here the next addon is neglected because recursion has been broken
                set(addons_list))
@blaggacao blaggacao changed the title [BUG] get_dependencies stops on first uninstallable module [BUG] get_dependencies stops on first uninstallable module within a given addons folder Jan 15, 2017
@nhomar
Copy link
Member

nhomar commented Oct 30, 2017

In the change of the architechture of the package this issue will be taken into account.

#500

@nhomar nhomar closed this as completed Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants