Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0+] mis_builder: non-admin user permission issues #415

Open
sbidoul opened this issue Feb 16, 2022 · 7 comments
Open

[15.0+] mis_builder: non-admin user permission issues #415

sbidoul opened this issue Feb 16, 2022 · 7 comments
Labels
15.0 bug no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Comments

@sbidoul
Copy link
Member

sbidoul commented Feb 16, 2022

You are not allowed to access 'Models' (ir.model) records.

I found this while trying to test the forward port of #410

@pedrobaeza
Copy link
Member

I think we can provide a selection with a restricted list of model names, and the modules adding extra models may feed such selection.

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 4, 2022
@sbidoul sbidoul added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Sep 4, 2022
@rafaelbn
Copy link
Member

rafaelbn commented Nov 8, 2022

This is a BUG. I can confirm it in production. We have to give all accountants admin right to work with MIS

Administration/Access Right

imagen

Is this related @sbidoul about what you said?

You are not allowed to access 'Models' (ir.model) records.

  • [FIX] l10n_es_aeat: do not require administration permissions #2583

@moduon MT-1527

@sbidoul
Copy link
Member Author

sbidoul commented Nov 8, 2022

Normally the error I had in mind with this issue occurred only when creating report templates.
But if it occurs when creating reports, then we can probably split this issue in two that can be fixed independently:

  1. make sure you don't need admin rights to view report templates and create reports
  2. make sure you don't need admin rights to create report templates

(1) should be easier to solve than (2).

yajo added a commit to moduon/mis-builder that referenced this issue Nov 9, 2022
Before this patch, normal users would get `AccessError` when trying to preview or print reports.

Fixes OCA#415.

@moduon MT-1527
yajo added a commit to moduon/mis-builder that referenced this issue Nov 9, 2022
Before this patch, normal users would get `AccessError` when trying to preview or print reports.

Fixes OCA#415.

@moduon MT-1527
yajo added a commit to moduon/mis-builder that referenced this issue Nov 9, 2022
Normal users get `AccessError` when trying to preview or print reports.

Tests OCA#415.

@moduon MT-1527
yajo added a commit to moduon/mis-builder that referenced this issue Nov 9, 2022
Normal users now don't get `AccessError` when trying to preview or print reports.

Fixes OCA#415.

@moduon MT-1527
@yajo
Copy link
Member

yajo commented Nov 9, 2022

Fix in #476

yajo added a commit to moduon/mis-builder that referenced this issue Nov 14, 2022
Normal users now don't get `AccessError` when trying to preview or print reports.

Fixes OCA#415.

@moduon MT-1527
yajo added a commit to moduon/mis-builder that referenced this issue Nov 14, 2022
Normal users get `AccessError` when trying to preview or print reports.

Tests OCA#415.

@moduon MT-1527
yajo added a commit to moduon/mis-builder that referenced this issue Nov 14, 2022
Normal users now don't get `AccessError` when trying to preview or print reports.

Fixes OCA#415.

@moduon MT-1527
sbidoul pushed a commit to acsone/mis-builder that referenced this issue Nov 14, 2022
Normal users get `AccessError` when trying to preview or print reports.

Tests OCA#415.

@moduon MT-1527
@sbidoul
Copy link
Member Author

sbidoul commented Nov 19, 2022

Keeping open as users still need admin right to create report templates.

dzungtran89 pushed a commit to dzungtran89/mis-builder that referenced this issue Jan 30, 2023
Normal users get `AccessError` when trying to preview or print reports.

Tests OCA#415.

@moduon MT-1527
dzungtran89 pushed a commit to dzungtran89/mis-builder that referenced this issue Mar 14, 2023
Normal users get `AccessError` when trying to preview or print reports.

Tests OCA#415.

@moduon MT-1527
dzungtran89 pushed a commit to dzungtran89/mis-builder that referenced this issue Mar 14, 2023
Normal users get `AccessError` when trying to preview or print reports.

Tests OCA#415.

@moduon MT-1527
@AnizR
Copy link
Contributor

AnizR commented Oct 18, 2024

I think that adding groups to mis_builder might be a good idea:

  • A group to read reports
  • A group to edit reports
  • A group to create and edit templates

An idea to tackle the problem of having access to ir_model and ir_model_fields:

  • Adding a configuration that only an admin (group_erp_manager) can set, that states the 'usable' models and fields
  • Having a Selection that displays those 'allowed models and fields' on templates

@sbidoul sbidoul changed the title [15.0] mis_builder: non-admin user permission issues [15.0+] mis_builder: non-admin user permission issues Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15.0 bug no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

No branches or pull requests

5 participants