Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tier validation record create with origin tier validation has comment #900

Open
wangyuhuiever opened this issue Jun 25, 2024 · 0 comments
Labels

Comments

@wangyuhuiever
Copy link

Module

The name of the module that has a bug.
base_tier_validation

Describe the bug

A clear and concise description of what the bug is.
There has two tier validation models. A and B, and definition A model has comment, and validate_tier A model and create B model in this method. It will update A model's review_ids fields res_id to B model's id.

To Reproduce

Affected versions:
16.0 verify and maybe others

Steps to reproduce the behavior:

  1. add A model tier_definition and check has_comment.
  2. inherit A model's validate_tier model and insert create B model method.
  3. fill comment and confirm.

Expected behavior
A model will see review_ids in approve state, but now disappear。after check tier.view record, the res_id change to B model id.

The affect code in tier_validation.py -> _add_comment method, 'default_review_ids': reviews.ids.
I fix this bug by override the context, create B model with_context({}), but I think this bug can be fixed by a more elegant way, so I submit this issue let you known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant