Optimize concept set doesn't remove redundant excluded concepts

[dimshitc]

Expected behavior

The peak concept was removed from the concept set definition, and concepts used to exclude parts of its hierarchy should be removed by the Optimize functions.

Actual behavior

those concepts excluding part of non existing hierarchy are present in concept set definition after Optimization.

Steps to reproduce behavior

test_concept_set.json

'Hyperfunctional dysphonia' exclude descendants is redundant since there's no parent of this concept included.
But Optimize doesn't remove it.

[anthonysena]

I'm not sure what you've requested is technically possible. When you remove the peak concept as you described, the optimize function will only consider the concepts included in the concept set. So, in this example, we presume the person creating the concept set has a reason for the exclusion of 'Hyperfunctional dysphonia' plus descendants. I'm going to close this out but let me know if I've misunderstood anything in this issue.

[anthonysena]

I take it back - this should be possible but will require some additional checks. In this particular example, we should evaluate the concept set in this way:

1. Obtain the list of concept(s) are included by evaluating those concepts in the concept set that are included (with or without descendants)
2. Given the results from step 1 above, evaluate if the excluded concepts (with or without descendants) would exclude anything from the list
3. Suggest to remove any excluded concepts that are not excluding anything from step 1