Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] PageViewController 제거 리팩토링 #269

Closed
3 tasks
youz2me opened this issue Jul 23, 2024 · 0 comments · Fixed by #272
Closed
3 tasks

[refactor] PageViewController 제거 리팩토링 #269

youz2me opened this issue Jul 23, 2024 · 0 comments · Fixed by #272
Assignees
@youz2me
Labels
♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고?

Comments

@youz2me
Copy link
Member

youz2me commented Jul 23, 2024 •
edited
Loading

📝 작업 페이지 캡쳐

페이지 캡쳐
피그마

작업할 브랜치

  • refactor/#269-pageviewcontroller-remove 브랜치에서 작업합니다.

✔️ To-Do

  • PageViewController 제거
  • Service 통합
  • ViewModel 통합
@youz2me youz2me added ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고? labels Jul 23, 2024
@youz2me youz2me self-assigned this Jul 23, 2024
youz2me added a commit that referenced this issue Aug 2, 2024
@youz2me
refactor/#269 ReadyStatusServiceType PromiseServiceType으로 병합
51dd0d8
youz2me added a commit that referenced this issue Aug 2, 2024
@youz2me
refactor/#269 준비 시간 설정 관련 파일 폴더링
1cfac01
youz2me added a commit that referenced this issue Aug 2, 2024
@youz2me
refactor/#269 PagePromiseViewController 이름 변경
37e6fc5
youz2me added a commit that referenced this issue Aug 2, 2024
@youz2me
refactor/#269 TardyService 삭제
bbab454
youz2me added a commit that referenced this issue Aug 2, 2024
@youz2me
delete/#269 SetReadyStatusINfoServiceType 위치 변경
33dc69a
youz2me added a commit that referenced this issue Aug 2, 2024
@youz2me
refactor/#269 PageViewController 제거 중간 커밋
c094e8d
youz2me added a commit that referenced this issue Aug 2, 2024
@youz2me
refactor/#269 ServiceType과 ViewModel 병합
18ae0c1
@youz2me youz2me mentioned this issue Aug 2, 2024
Merged
@youz2me youz2me linked a pull request Aug 2, 2024 that will close this issue
[Refactor] 약속 상세 뷰 ServiceType과 ViewModel 병합 #272
Merged
youz2me added a commit that referenced this issue Aug 3, 2024
@youz2me
fix/#269 코드리뷰 반영
48a74de
youz2me added a commit that referenced this issue Aug 4, 2024
@youz2me
Merge pull request #272 from OMZigak/refactor/#269-pageviewcontroller…
56a913b 
…-remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youz2me youz2me

Labels
♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Refactor] 약속 상세 뷰 ServiceType과 ViewModel 병합 OMZigak/KKUYOS
1 participant
@youz2me