Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: Clean up interface to work in light mode and fit within Notebook #45

Closed
WarmCyan opened this issue Aug 21, 2024 · 3 comments

Comments

@WarmCyan
Copy link
Collaborator

As pointed out by @jhagerer in openjournals/joss-reviews#6873 (comment), the interface doesn't render effectively in a light mode themed Jupyter instance, and is squished within Jupyter Notebook cells (as opposed to Jupyter Lab.)

Copying the example image over here for reference:
image

@WarmCyan WarmCyan changed the title JOSS Review: Clean up interface to work in light mode and fit within Notebook JOSS review: Clean up interface to work in light mode and fit within Notebook Aug 21, 2024
@jhagerer
Copy link

Hey @WarmCyan , in case to speed up the review process, an easy quick win could also be achieved as follows: Just change the documentation by telling that you need to activate dark theme for Jupyter Lab. You can refer to the following link:

https://stackoverflow.com/a/46219796/776847

@WarmCyan
Copy link
Collaborator Author

As it turned out solving the theming issue was much easier than making it fit in Jupyter Notebook. The interface should now be usable in both light-theme and dark-theme Jupyter Lab:
image

Note that this required an update to our underlying ipyanchorviz package, so your environment will need to be updated with pip install --upgrade ipyanchorviz

I wasn't able to find a good solution for making it fit correctly inside a Notebook cell -- the space is heavily constrained and there's not an easy way of detecting or overriding this. For now, I'm going to update the documentation to state that this is intended for use only in Jupyter Lab

@jhagerer
Copy link

jhagerer commented Oct 6, 2024

I can confirm that this issue is solved now. Please close.

@WarmCyan WarmCyan closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants