Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive apps menu customization filter out Passenger apps #3015

Open
robinkar opened this issue Sep 7, 2023 · 2 comments
Open

Interactive apps menu customization filter out Passenger apps #3015

robinkar opened this issue Sep 7, 2023 · 2 comments

Comments

@robinkar
Copy link
Contributor

robinkar commented Sep 7, 2023

I'm might have missed some part of the documentation that makes this possible right now, but there doesn't seem to be an easy way to filter out Passenger apps in the interactive app menu / navbar menu customization.

Right now we have an app category called Tools, which includes both Passenger apps (login node shell and other utils), and interactive apps (e.g. persistent compute node shell). In the navbar we would like to show these together as one group (category), while in the interactive apps menu we would like to show only the interactive apps.

This is somewhat related to #3014, as a configuration like this does not make much sense currently. With a configuration like the one below, the interactive apps menu includes also Passenger apps. Filtering by something like role: batch_connect could be expected to work as that is defined in the manifest.yml, but it does not work. I suppose metadata could be used here, but seems unnecessary to explicitly define whether apps are interactive or Passenger apps there.

interactive_apps_menu:
  title: "Apps"
  links:
    - apps:
      - type: sys # this could be just too "sys/*"
      # In the real config we'd have some category/subcategory/metadata filters here
@osc-bot osc-bot added this to the Backlog milestone Sep 7, 2023
@johrstrom
Copy link
Contributor

Interactive Apps is the category, so I'm not sure how you have a Tools category with interactive apps in it. (tools is the subcategory?)

Here's our rstudio just as a random example.
https://github.com/OSC/bc_osc_rstudio_server/blob/4342ba8a7ffe25b47d0647eed96f83c383a9bb57/manifest.yml#L3

@robinkar
Copy link
Contributor Author

robinkar commented Sep 8, 2023

We've had it like that for quite a long time now, since we have wanted to group the shell apps together into the same dropdown in the navmenu.
I.e. Compute node shell here is an interactive app (with category: Tools and no subcategory), the others in the Tools category are Passenger apps:
image

In the interactive app page it shows up like this:
image
This seems to not be possible anymore when customizing the interactive apps menu, since it now goes into the same box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants