Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the dangers of greedy host_regex expression (it must not match on /) #3130

Closed
Micket opened this issue Oct 18, 2023 · 1 comment
Closed
Milestone

Comments

@Micket
Copy link
Contributor

Micket commented Oct 18, 2023

I spent some time debugging why some of my apps didn't work correctly, when I eventually discovered I had been neglectful when specifying my host_regex configuration. I had done something like

host_regex: "foo.*"

which will cause confusing issues, no error messages (from what I could find), but apps either didn't work, or just partially didn't work.
Example, the desktop app still worked fine, while a jupyter notebook will launch the browser just fine, but won't be able to connect to any python kernel.
Other fails to find most of it's linked material, leaving a typical white page and maybe a favicon.

While the examples do correctly show regex which correctly excludes /, I think it would help to make this requirement explicitly written in the docs, otherwise strange things will happen with the proxy'ing.

https://osc.github.io/ood-documentation/latest/reference/files/ood-portal-yml.html?highlight=host_regex#configure-reverse-proxy

@Oglopf
Copy link
Contributor

Oglopf commented Oct 27, 2023

Hey, thanks for this! I've linked this issue and copied it over to our docs repo to make sure it gets picked up. So, I'm closing it here but you can find the new ticket at:
OSC/ood-documentation#883

@Oglopf Oglopf closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants