Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors in custom widgets can produce 500 internal server error #3539

Closed
johrstrom opened this issue Apr 30, 2024 · 0 comments · Fixed by #3873
Closed

errors in custom widgets can produce 500 internal server error #3539

johrstrom opened this issue Apr 30, 2024 · 0 comments · Fixed by #3873
Assignees
Labels
bug Existing functionality not working as expected component/dashboard
Milestone

Comments

@johrstrom
Copy link
Contributor

While debugging #3452 I found that the response Rails gives is actually 500.

Here are the error logs for reference.

App 391 output: [2024-04-30 19:33:25 +0000 ] FATAL "LoadError (cannot load such file -- sqlite3):\n  \napp/helpers/dashboard_helper.rb:43:in `render_widget'\napp/views/dashboard/index.html.erb:13\napp/views/dashboard/index.html.erb:12:in `each'\napp/views/dashboard/index.html.erb:12\napp/views/dashboard/index.html.erb:9:in `each'\napp/views/dashboard/index.html.erb:9\napp/views/dashboard/index.html.erb:7:in `each'\napp/views/dashboard/index.html.erb:7"
App 391 output: [2024-04-30 19:33:25 +0000 ]  INFO "method=GET path=/pun/sys/dashboard/500 format=html controller=ErrorsController action=internal_server_error status=500 allocations=8878 duration=8.74 view=6.19"

Instead of fatally crashing - we should just account for LoadErrors or other Exceptions.

@johrstrom johrstrom added bug Existing functionality not working as expected component/dashboard labels Apr 30, 2024
@johrstrom johrstrom added this to the 4.0 milestone Apr 30, 2024
@johrstrom johrstrom self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality not working as expected component/dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant