Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate alerts in files app #3761

Closed
johrstrom opened this issue Aug 28, 2024 · 0 comments · Fixed by #3769
Closed

duplicate alerts in files app #3761

johrstrom opened this issue Aug 28, 2024 · 0 comments · Fixed by #3769

Comments

@johrstrom
Copy link
Contributor

The way the files app shows alerts is a little funny, I think because of the Uppy integration and when errors can occur.

Here's an example of how it can be a little wonky. You see here there's a Rails flash message (in red on the page) and that's in addition to an Uppy modal that pops up.

image

For me an my taste, I'd like to just use Rails flashes (obviously triggered by javascript events and made in javascript in some cases) to be consistent across the entire application. That way, error displays are the same across all pages. This will provide a consistent UX.

Related to #2592 because I think these extra alerts from from sweet alert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants