Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or increase limit on rating #723

Open
Kovoschiz opened this issue Mar 14, 2024 · 8 comments
Open

Remove or increase limit on rating #723

Kovoschiz opened this issue Mar 14, 2024 · 8 comments

Comments

@Kovoschiz
Copy link

Kovoschiz commented Mar 14, 2024

I'm submitting a feature request

Brief Description

Remove or delay "request was throttle" HTTP 429 on https://osmcha.org/api/v1/changesets/*/set-harmful/ and https://osmcha.org/api/v1/changesets/*/set-good

What is the motivation / use case for this feature?

Flagging a series of low to single object count changesets for follow-up (I don't care about good/bad)

Other Information / context:

I don't know whether this is for containing server load, or abuse. For the latter, this should be measured by the number of objects affected, not per changeset which can be of any size.

@Kovoschiz Kovoschiz changed the title Remove limit on rating Remove or increase limit on rating Mar 14, 2024
@matkoniecz
Copy link

Note that some people spammed pointless comments using osmcha, this limits how much pointless spam they can create.

@pwithnall
Copy link

If they’re spamming, their accounts should get blocked by moderators, surely? The request rate limiting makes osmcha significantly less useful for good-faith users to use to review large (or even medium) numbers of changesets.

@matkoniecz
Copy link

their accounts should get blocked by moderators, surely?

Well, it would happen afterwards and meantime they would as much as osmcha/changeset rate limiting would allow.

@Kovoschiz
Copy link
Author

Can't giving thumbs and commenting be limited separately?

@matkoniecz
Copy link

Both result in changeset comment and trigger the same notification for affected user, right?

@pwithnall
Copy link

Giving thumbs does not result in a changeset comment unless the OSMCha user has configured one (‘Review Comments Template’ in their OSMCha account settings). I have mine set to blank (no comment).

@matkoniecz
Copy link

Then if thumbs up remain in osmcha - then separate action limit would make sense, probably

@ComradeRamen
Copy link

I just end up not marking all bad changesets as such when I hit the rate limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants