Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove original from the User Agent field (and replace with what?) #9

Open
oshezaf opened this issue Jul 22, 2021 · 3 comments
Open
Assignees

Comments

@oshezaf
Copy link

oshezaf commented Jul 22, 2021

As a reminder, in one of our recent discussions we decided to remove the suffix original from this and similar headers. This is challenging for User Agent as it is defined as an entity and "original" is essentially the field name. Maybe having UA as an entity rather than an HTTP attribute is the culprit?

@oshezaf oshezaf changed the title Remove original from the User Anent field (and replace with what?) Remove original from the User Agent field (and replace with what?) Jul 22, 2021
@neu5ron
Copy link

neu5ron commented Aug 25, 2021

user agent, since is a part of multiple types of (for the sake of this conversion using the word) Entity/logs.
SIP
HTTP
QUIC
etc..
I believe moving it under HTTP would result in losing the relationship/pivoting aspect of user agent.
@oshezaf @Cyb3rWard0g thoughts?

@oshezaf
Copy link
Author

oshezaf commented Sep 15, 2021

I personally don't take user agent to be an entity. It is an attribute, potentially of different entities. That said, the OSSEM paradigm is that everything is entities and I guess I will have to adjust.

That said, it leaves us with a unique challenge here, as user agent has just one attribute, and using "original" forces a specific use for it. I guess that it has to be renamed to just "name", or something more generic.

@Cyb3rWard0g , @neu5ron

@neu5ron
Copy link

neu5ron commented Sep 17, 2021

@oshezaf we can just make it user_agent same concept as a url. Does that work?

cc: @Cyb3rWard0g thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants