Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.1.3 seems like nonsense #1381

Closed
jmanico opened this issue Sep 28, 2022 · 8 comments
Closed

8.1.3 seems like nonsense #1381

jmanico opened this issue Sep 28, 2022 · 8 comments

Comments

@jmanico
Copy link
Member

jmanico commented Sep 28, 2022

8.1.3 makes absolutely no sense

From: https://github.com/OWASP/ASVS/blob/master/5.0/en/0x16-V8-Data-Protection.md

8.1.3 [GRAMMAR] Verify the application minimizes the number of parameters in a request, such as hidden fields, Ajax variables, cookies, and header values.   233
@elarlang
Copy link
Collaborator

The sense for example - instead of keeping already submitted data on the service side, some app carries entire package in hidden fields / in some JSON object etc.

It is problematic also with some restful stuff, where entire datasets are sent back and forward when only few items are needed.

@jmanico
Copy link
Member Author

jmanico commented Sep 29, 2022

The sense for example - instead of keeping already submitted data on the service side, some app carries entire package in hidden fields / in some JSON object etc.

It is problematic also with some restful stuff, where entire datasets are sent back and forward when only few items are needed.

Server vs client-side data is a different issue covered elsewhere. I do not think the field number really matters. This, IMO, needs to be clarified or just removed. We have bigger issues to focus on.

@elarlang
Copy link
Collaborator

From the "data protection" category perspective this requirement is at least in wrong place. We can minimize unnecessary bandwidth from client to server with that, but it's not a data protection issue.

@jmanico
Copy link
Member Author

jmanico commented Sep 29, 2022

And having many parameters vs JSON is actually SAFER since you do not need to utilize a server-side JSON parser.

I again assert this requirement is nonsense. Many apps require lots of parameters for good reason.

I do see EXTRA parameters the app does not need as a good intrusion detection point. But many parameters is just how some apps work, and that does not add a security risk in an of itself.

@elarlang elarlang added the 5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR label Sep 29, 2022
@jsulinski
Copy link
Contributor

I agree, this requirement is too vague to be useful.

@tghosth
Copy link
Collaborator

tghosth commented Sep 29, 2022

Do we have any idea what the original rationale was here? Can we see from blame or previous issues?

@jsulinski
Copy link
Contributor

jsulinski commented Sep 29, 2022

Doesn't seem to exist in ASVS 1.0.
Exists in ASVS 2.0 as 9.7.
Exists in ASVS 3.0.1 as 9.7.
Renumbered from 9.7 to 9.8 in 2019.
Renumbered from 9.8 to 9.1.3 in 2019.
Renumbered from 9.1.3 to 8.1.3 in 2019.
Some previous discussion in 2021.

@jsulinski
Copy link
Contributor

It looks like ASVS 2.0 predates git repo usage.

Anyone know where changes were discussed before git?

elarlang pushed a commit to elarlang/ASVS that referenced this issue Sep 30, 2022
@elarlang elarlang self-assigned this Sep 30, 2022
@elarlang elarlang added 6) PR awaiting review and removed 5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR labels Sep 30, 2022
danielcuthbert added a commit that referenced this issue Oct 1, 2022
@elarlang elarlang closed this as completed Oct 1, 2022
elarlang pushed a commit to elarlang/ASVS that referenced this issue Jan 3, 2023
tghosth pushed a commit that referenced this issue Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants