Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yellow Colour makes links hard to see in the "Know More" pages #118

Open
ceilican opened this issue Oct 12, 2016 · 8 comments
Open

Yellow Colour makes links hard to see in the "Know More" pages #118

ceilican opened this issue Oct 12, 2016 · 8 comments

Comments

@ceilican
Copy link
Contributor

No description provided.

@AnandKumar22
Copy link

Instead of giving it any color can we make some small transition type while hovering like scaling the menu or changing the background of the nav.....I think this would surely work out..

@ceilican
Copy link
Contributor Author

ceilican commented Jan 4, 2017

Links should be visible even before the user decides to hover on them. So, yellow should definitely be replaced by a better color. Whoever decides to fix this issue should study a little bit of color theory, in order to choose an elegant and visible color.

It is usually not elegant to have special effects when hovering. I would not recommend that.

@AnandKumar22
Copy link

AnandKumar22 commented Jan 6, 2017 via email

@boro741
Copy link
Contributor

boro741 commented Jan 6, 2017

@ceilican
Copy link
Contributor Author

ceilican commented Jan 6, 2017

Also, there are many tutorials on how to use git and GitHub out there. Make sure you read those. You should do the following steps:

  1. fork this repository
  2. clone your fork into your own local computer
  3. make the changes you want in the files in your computer
  4. commit and push your changes to your fork
  5. make a pull request through GitHub

@AnandKumar22
Copy link

I have tried to solve this issue please have a look at the pull request and comment if further modification is needed..

AnandKumar22 added a commit to AnandKumar22/CarbonFootprint that referenced this issue Jan 7, 2017
@ceilican
Copy link
Contributor Author

ceilican commented Jan 7, 2017

I left a comment in the code...

sanket0211 added a commit to sanket0211/CarbonFootprint that referenced this issue Jan 23, 2017
sanket0211 added a commit to sanket0211/CarbonFootprint that referenced this issue Jan 23, 2017
ceilican added a commit that referenced this issue Jan 25, 2017
Solved Issue #118. Yellow Colour makes links hard to see in the 'Know More' pages
@AnandKumar22
Copy link

@sanket0211 please have a look at the air index page,it has a problem regarding the positioning of the gray background box and the menu options.
@ceilican I think that for that page it already has a map,so we should leave the background blank.I think that will look better rather than any gray or black background.
screenshot 25
screenshot 24

r0hit-gupta pushed a commit to r0hit-gupta/CarbonFootprint that referenced this issue Mar 7, 2017
fixed issue OiWorld#118

See merge request !129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants