Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Call main function when evaluating file in Rust evcxr #399

Closed
glyh opened this issue Aug 21, 2022 · 4 comments
Closed

[FR] Call main function when evaluating file in Rust evcxr #399

glyh opened this issue Aug 21, 2022 · 4 comments
Labels
client-rust enhancement New feature or request

Comments

@glyh
Copy link
Contributor

glyh commented Aug 21, 2022

As title.

I think it would be more ergonomic to just call the main function and ask parmeters of it to user if necessary.

BTW, rust client seems to print a lot of stuffs on the REPL as comments, I personally don't like this approach. We could improve it maybe via writing a customized version of REPL based on some core evcxr libraries.

@Olical Olical added enhancement New feature or request client-rust labels Aug 24, 2022
@Olical
Copy link
Owner

Olical commented Aug 31, 2022

@rafaeldelboni would love your opinion on this one too! I appreciate that you may just not know about this sort of thing either.

@rafaeldelboni
Copy link
Contributor

Is possible to call the main function via the stdio interface? If not that would need a complete rewrite of the integration, but I wouldn't mind of is there a good documentation about how to do this.

About the customized repl based on evcxr libraries, I totally would go using nrepl protocol instead of stdio like the current one if I was going to make one.

And I'm sorry if I used/integrated anything wrong, I just had the idea of integrating a rust repl while I was studying rust after years working with clojure.

@glyh glyh changed the title [FR]Call main function when evaluating file in Rust evcxr [FR] Call main function when evaluating file in Rust evcxr Aug 31, 2022
@Olical
Copy link
Owner

Olical commented Aug 31, 2022

And I'm sorry if I used/integrated anything wrong, I just had the idea of integrating a rust repl while I was studying rust after years working with clojure.

Oh no no, you did great, I think anything is better than nothing, I don't expect every client to do everything everyone wants ever. I only roped you in here for your input since you have the most context... compared to me especially!

@glyh
Copy link
Contributor Author

glyh commented Jun 21, 2023

Close in favor of more generalized #508 . That one is closed as well because it should be implement in LSP/DAP. We can keep conjure simple by not implementing this feature.

@glyh glyh closed this as completed Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-rust enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants