Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question]: OneSignal iOS SDK size not optimal for app clips. Can we shrink the size of SDK. #1438

Open
1 task done
Nishannb opened this issue May 21, 2024 · 5 comments
Open
1 task done

Comments

@Nishannb
Copy link

Nishannb commented May 21, 2024

How can we help?

I recently integrated oneSignal notification for app clips which has the size limit of 10MB (for making it work in most iphones).
But the size of OneSignal iOS SDK itself is 6.5MB, is there any way we can shrink the size of SDK.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jkasten2
Copy link
Member

@Nishannb could you explain where you are seeing this increase? Is it increasing the size of your app at the Xcode Archive phase or the end result, such as what is reported by test flight.

To lower the size you can omit parts of the OneSignal SDK you don't use, example In-App Messages and location.

@Nishannb
Copy link
Author

_Yes, after the Xcode Archive phase, I checked the Framework size.
I do parts of framework that I don't use, I want to make sure which I can omit without affecting what's working i.e. notification feature.

The app is built on react native and when I check the onesignal docs for react native SDK, it mentions entire framework to be added. I could not find a way for selecting sub-specs. Is there any way you can help ?

FYI, this is the framework folder screenshot I have.
Screenshot 0006-05-22 at 10 29 01

@emawby
Copy link
Contributor

emawby commented May 22, 2024

@Nishannb Thank you for reaching out. Yes the lack of modularity is currently a limitation of our react native SDK and is something we are looking to address in the future.

@Nishannb
Copy link
Author

Is there a timeline we look forward to for react native SDK. We want to reimplement onesignal notification in our project but the size became the bottleneck as we want to run on app clips and instant apps.

@emawby
Copy link
Contributor

emawby commented Jun 6, 2024

There is no timeline to share at the moment, I apologize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants