Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to make Link drop Ruto applies to all doors in that room #2136

Open
r0bd0g opened this issue Nov 12, 2023 · 2 comments
Open

Hack to make Link drop Ruto applies to all doors in that room #2136

r0bd0g opened this issue Nov 12, 2023 · 2 comments
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Type: Bug Something isn't working

Comments

@r0bd0g
Copy link

r0bd0g commented Nov 12, 2023

I'm not sure for what reason you would want to bring Ruto back through those doors except in maybe some super niche glitched play circumstances. That's probably why nobody noticed this before.

@fenhl fenhl added Type: Bug Something isn't working Component: ASM/C Changes some internals of the ASM/C libraries labels Nov 12, 2023
@fenhl
Copy link
Collaborator

fenhl commented Feb 15, 2024

Why does this hack exist in the first place?

For reference, here's the code implementing the hack in question:

;==================================================================================================
; Clean Up Big Octo Room For Multiple Visits
;==================================================================================================
;make link drop ruto if "visited big octo" flag is set
;Replaces: lh t9, 0x1C(s0)
; lh t6, 0x1C(s0)
.orga 0xD4BCB0
jal drop_ruto
lh t9, 0x1C(s0)
;kill Demo_Effect if "visited big octo" flag is set
;Replaces: sw a1, 0x64(sp)
; lh v0, 0x1C(s0)
.orga 0xCC85B8
jal check_kill_demoeffect
sw a1, 0x64(sp)

@r0bd0g
Copy link
Author

r0bd0g commented Feb 15, 2024

The big octo room glitches out if you bring ruto in a 2nd time. But for best results we gotta make it only apply to the door to big octo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants