Logic for repeatable blue warp ToD changes #2304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added
Type: Bug
|
I'm not convinced this is a good idea. On one hand I feel like, if it exists, it should be in logic. On the other hand, this is such an obscure change from vanilla oot. I don't know that I want the average player to have to know about this one obscure change to be able to beat a seed. (Regardless, I think the "provides_time" thing is a good change?) |
|
I think documenting this at https://wiki.ootrandomizer.com/index.php?title=Logic#Vanilla_Mechanics_Changed_by_Randomizer as well as the tooltip for blue warp ER (PR soon™), in addition to the announcement that's already been posted to #racing-announcements, should be sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2235. Part 2 of 2.
This puts the repeatable time-of-day changes from blue warps that were introduced in #2287 into logic. The logic is handled in the same way as for outside Ganon's Castle, which was previously a hardcoded special case.