Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing vote text in console? #23

Open
The-Gig opened this issue Apr 8, 2018 · 7 comments
Open

Printing vote text in console? #23

The-Gig opened this issue Apr 8, 2018 · 7 comments
Labels
enhancement Things to spice up our game.

Comments

@The-Gig
Copy link
Contributor

The-Gig commented Apr 8, 2018

Hello.
When someone asks for a vote, it's possible to notice that the console doesn't show the text of the vote, hence it's not logged, while it may be an interesting info for admins managing servers (you cannot know what has been voted for, especially if the vote failed). What about adding it?
I don't know whether it would be a gamecode or engine thing, but I can guess the voting code should be in gamecode... (well, maybe one may "intercept" votes from engine to apply the change also to old mods, but probably that would be a more "hacky" thing, probably not worth it).

Note: in case of custom votes (http://openarena.wikia.com/wiki/Custom_votes), I don't know if it would be better to show "votecommand", "displayname" or "command" value, probably "displayname".

@sago007
Copy link
Member

sago007 commented Apr 8, 2018

It would make sense to log it.
Who called which vote
Who voted yes/no
What was the result

I believe that custom votes should be logged with its "votecommand" as key. Display command can be in the comment field.

I would be against letting the engine intercept it. I am against any interference for old mods, as the cost is always too big.

@The-Gig
Copy link
Contributor Author

The-Gig commented Apr 8, 2018

"Who" called a vote is already logged (but not which vote... that's the reason I opened this issue). Also what was the result (just as "passed" or "failed"... of course that may be improved by adding "yes w, no x, null y, required z" - z may vary if "light voting" dmflags is set).

About listing the final vote of each player, I don't know if such info should be public (for completeness and transparency) or not (for privacy and not flooding console output... maybe a small delay between lines?)...

@The-Gig
Copy link
Contributor Author

The-Gig commented Apr 9, 2018

I think that it should be possible to add the info in the same lines, to do not flood the console output (especially thinking about console feedback area in upper left corner).
I mean, "PlayerOne called a vote." may become "PlayerOne called a vote: map wrackdm17." or "PlayerOne called a vote: custom lms_custom."...
Similarily, "Vote passed." may become "Vote passed. Yes: 5, No: 2, Null: 1, Required: 3."
Maybe one of the two lines may even mention "Light voting (is) enabled." in case it is.

Note: maybe there is some better word than "null" to say who didn't vote at all, I don't know.

@The-Gig
Copy link
Contributor Author

The-Gig commented Sep 7, 2018

In August, you implemented the "print in console what has been voted for" thing, thank you very much!
f1e36de
I did a quick test and it seems to work correctly.
Additional suggestions (log yes/no/required counts, and lightvoting-dmflags 512-) are still valid. :-)

@The-Gig
Copy link
Contributor Author

The-Gig commented Sep 7, 2018

Excuse me, looking at the code, I see there are different results strings:
"Vote passed. At least 2 of 3 voted yes" [Is a final dot missing here?]
"Vote passed. More yes than no."
"Vote passed."
During my tests I only get the third one on console. Is this due to my tests do have only one or two players in the server, and the first and second string are used when there is at least a certain number of people? Or the reason is something else?
About the first two strings, it looks like the first one is meant to be shown in case of "classic" voting and the second one in case of "light" voting.... so there is already "something" to distinguish between them...

@NeonKnightOA NeonKnightOA added bug Something went wrong. enhancement Things to spice up our game. and removed bug Something went wrong. labels Mar 14, 2024
@NeonKnightOA

This comment was marked as abuse.

@NeonKnightOA

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Things to spice up our game.
Projects
None yet
Development

No branches or pull requests

3 participants