From 861e667570aced1774bf2abab0e8c8f18a27da8a Mon Sep 17 00:00:00 2001
From: Matti Kaupenjohann <matti.kaupenjohann@fh-dortmund.de>
Date: Thu, 18 Apr 2024 21:13:12 +0200
Subject: [PATCH] Feature: Improve admin needed error msg

- Add method isInElevatedGroup
- check if the linux user is in plugdev
- add logic for admin error check
---
 OpenBCI_GUI/Extras.pde      | 28 ++++++++++++++++++++++++++++
 OpenBCI_GUI/OpenBCI_GUI.pde |  4 ++--
 2 files changed, 30 insertions(+), 2 deletions(-)

diff --git a/OpenBCI_GUI/Extras.pde b/OpenBCI_GUI/Extras.pde
index b6e50c341..c41cfb8a9 100644
--- a/OpenBCI_GUI/Extras.pde
+++ b/OpenBCI_GUI/Extras.pde
@@ -158,6 +158,34 @@ public boolean isElevationNeeded(String path) {
     }
     return result;
 }
+/**
+* Determines if user is in elevated group (plugdev).  
+*
+* @return <code>true</code> if user is in group plugdev, <code>false</code> otherwise.
+ */
+public boolean isInElevatedGroup() {
+    boolean result = true;
+    if (isLinux()) {
+        try {
+            String command = "groups";
+            Process p = Runtime.getRuntime().exec(command);
+            p.waitFor();
+            InputStream stdIn = p.getInputStream();
+            BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(stdIn));
+            String[] values = bufferedReader.readLine().split(" ");
+            for (int idx=0; idx<values.length; idx++) {
+                result = values[idx].equals("plugdev");
+                if (result) {
+                    break;
+                }
+            }
+        } catch (Exception e) {
+            return false;
+        }
+    }
+    return result;
+}
+
 /**
 * Determine if user has administrative privileges.
 *
diff --git a/OpenBCI_GUI/OpenBCI_GUI.pde b/OpenBCI_GUI/OpenBCI_GUI.pde
index 0d2281425..63ff077ed 100644
--- a/OpenBCI_GUI/OpenBCI_GUI.pde
+++ b/OpenBCI_GUI/OpenBCI_GUI.pde
@@ -497,8 +497,8 @@ void delayedSetup() {
     //Apply GUI-wide settings to front end at the end of setup
     guiSettings.applySettings();
 
-    if (!isAdminUser() || isElevationNeeded()) {
-        outputError("OpenBCI_GUI: This application is not being run with Administrator access. This could limit the ability to connect to devices or read/write files.");
+    if (!isInElevatedGroup() && (!isAdminUser() || isElevationNeeded())) {
+        outputError("OpenBCI_GUI: This application is not being run with Administrator access or user is not member of plugdev group. This could limit the ability to connect to devices or read/write files.");
     }
 }