Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening an invalid peerID opens a blank store #52

Open
jjeffryes opened this issue Jun 12, 2018 · 1 comment
Open

Opening an invalid peerID opens a blank store #52

jjeffryes opened this issue Jun 12, 2018 · 1 comment

Comments

@jjeffryes
Copy link

If you try to open an invalid store, like http://openbazaar.com/store/QmTMnWLbHgxjBNSr5a48yS4LQBhdUud7AvxyHfuRhuU3qj (this is a testnet store), the screen is blank for a long time and then generates a store with all of the data missing.

It would be better to have a 404 screen of some kind, I think.

@jjeffryes jjeffryes changed the title Opening an invalid store opens a blank store Opening an invalid peerID opens a blank store Jun 12, 2018
@rmisio
Copy link

rmisio commented Jun 12, 2018

Hmm... it would be interesting to see what the profile fetch is returning. My assumption is that is should return an error (non 200 code) which I believe would then route the user to a User Error page. I believe it was doing this before.

If the server is returning a success with blank profile data, I think this is a server bug.

EDIT: Ok, disregard this comment. I thought this was a bug in the desktop client... lol. @jjeffryes threw me a wicked curveball ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants