Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Rotate the page #1136

Open
sebojolais opened this issue Oct 12, 2024 · 10 comments
Open

[Feature Request] Rotate the page #1136

sebojolais opened this issue Oct 12, 2024 · 10 comments

Comments

@sebojolais
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  • Problem 1:
    I have some PDF documents as ressources for my classroom. Some of them have mistake in the page oriention. When I import PDF documents in OpenBoard, the pages are shown as background in the bad orientation.
  • Problem 2:
    I have a map as background on a page, for example: the classroom map. And it is more intuitive to show the map with a rotation compare to the position of the students in front of the board/screen.

Describe the solution you'd like
For the 2 problems, the solution could be a 90° rotation of the page.

Where we can imagine the feature?
Currently we can arrange pages in the thumbnail left dock. On each page, there are 2 button: for deleting or duplicating the page. We can add one button to rotate the page. Each action on the button throws a 90° rotation in clockwise. So by 1, 2 or 3 clicks, we manage the 3 kinds of rotation. Have a look below for a sketchup:
Screenshot_20241006_150122

Describe alternatives you've considered

  • I think this feature could not be in the document mode because this mode is more a file manager mode where we do not manage the aspect of the pages.
  • This feature could be also in a context menu on the board view on a page. But currently there is no context menu on the board (only on applications). So it is not a good idea to create one just for this feature.

Additional context
Could you give a feedback like a go/no-go because I propose to implement it but I do not want to spent energy if it could not be accepted.

@letsfindaway
Copy link
Collaborator

I also have something like this on my list since years (letsfindaway#8) but did not work further. However I would support such a feature and attaching it to the thumbnails view seems to be a good idea to me.

@sebojolais
Copy link
Contributor Author

Hi Martin,
Thank you for your answer and your support.
Just a detail:
Your issue speaks about rotation of the background object and it was also my initial idea.
But after sometime, I switched the feature to rotate the page and not only background object because:

  • If you rotate the entire page, you rotate the background object also
  • And it could make sense to rotate the entire page in some use-cases.

@sebojolais sebojolais changed the title [Feature Request] Rotate the pages [Feature Request] Rotate the page Oct 13, 2024
@letsfindaway
Copy link
Collaborator

letsfindaway commented Oct 13, 2024

Just some comments for rotating the full page:

  • There are items (e.g. web widgets) which cannot be rotated individually. I'm not sure whether we could rotate them when rotating the full page and what consequences this could have. At least it would require that we make any currently unrotatable item rotatable.
  • And if your page only contains rotatable items, then we already have some means to do that:
    • Select all by using the rubber band or by pressing Ctrl+A.
    • Group the items.
    • Rotate the group.
    • Ungroup the items.

This does however not work when your selection contains any item which cannot be rotated.

@sebojolais
Copy link
Contributor Author

Yes, we have to keep in mind issues with unrotatable objects.

In other hand, if the page is not empty, rotate only the background object and not the others could sound strange and not user-friendly.

Maybe an intermediate solution could be:

  • rotate the background object
  • rotate the rotatable objects
  • and no rotation for unrotatable objects

We could show a warning message if there are some unrotatable objects to say "Some objects could not be rotated."

@letsfindaway
Copy link
Collaborator

In fact, I don't yet see a convincing use case that would justify introducing a new feature for rotating the entire page.

Rotating the background is currently not possible. In my opinion, this justifies a new feature, as this is sometimes necessary. Examples are PDF files with incorrect page orientation or photos with missing or incorrect information about their orientation.

However, the workflow I described already exists for the items on the page: group items and rotate the group. Some rework may still be necessary in individual cases, but it is also easy to move or scale the group.

Rotating the background and items separately may be a little more complex. However, I think this is perfectly acceptable for the few cases where it is needed.

@sebojolais
Copy link
Contributor Author

sebojolais commented Oct 16, 2024

I agree with your arguments.

If we want to rotate the background and not the page:

  • We can not see the feature on the location described above. Because if the 2 first buttons (delete or duplicate) action the page, the user will imagine the same for the third.
  • We can not show a dialog box at each background object creation to propose a rotation because the user experience will decrease for everybody even though the rotation will be used in few case.

I am sorry because just able to say where I can not imagine this feature but no idea where it could be at the right place...

Maybe we can close this ticket rotate the page and open another called rotate background object ?

@kaamui
Copy link
Member

kaamui commented Oct 17, 2024

Hi @sebojolais !

Sorry for my late reply. There are things planned internally about this, but it somehow embraces more things than just rotating the PDF, even if the initial goal was that. One of the issue you have (and that I had too) on "where to put this feature ?" should be solved with the potential changes around page Size rework.

I created a Project, very basic as a first step, to share with you and others some internal informations, to help on this. I'll replace some of the items by opened discussions when I find time for it).

Please forgive the temporary raw state of it : https://github.com/orgs/OpenBoard-org/projects/1

@sebojolais
Copy link
Contributor Author

Hi @kaamui ,
Thank you for your answer.
Nice to see a front-end of your internal topics 👍 great job!

@letsfindaway
Copy link
Collaborator

I also welcome this project page very much. Thank you!
I'm just missing the flexible background patterns from this list.

@kaamui
Copy link
Member

kaamui commented Oct 30, 2024

I'm just missing the flexible background patterns from this list.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants