Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refreshing TableDirectoryListing on WatchService notification instead of 1-minute interval #924

Open
glukos opened this issue Oct 12, 2021 · 0 comments
Labels

Comments

@glukos
Copy link
Contributor

glukos commented Oct 12, 2021

TableDirectoryListing#refresh can be a heavy operation, especially if a frequent roll cycle is chosen. e.g. RollCycles#MINUTELY.
Even though the allocation issue is mitigated under #922, calling it once a minute may cause latency spikes. We should consider registering a WatchService in queue in order to trigger refresh only on start or if queue files were manually moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants