Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for filters (Maven variables) & WAR overlays - PART 2: WAR-in-EAR modules #1712

Open
scottkurz opened this issue Aug 9, 2023 · 3 comments

Comments

@scottkurz
Copy link
Member

scottkurz commented Aug 9, 2023

This issue continues the work described in epic #1104.

In that epic, we socialized and received approval for a design for handling resource filtering and WAR overlays, as well as for applying filtering to server config (server.xml, etc.).

At this point, we're refactoring the issue descriptions to carve out and separate the piece that we implemented vs. the pieces that we did not.

This issue will be used to track a key piece remaining: the addition of the web resources filtering to WAR modules within EAR modules.

Note the UFO design is at: https://ibm.box.com/s/k6zinwfzvwfzfp0fl4mv7fv9mbmuubfa

The part related to EAR modules is described in slides 23-27

Note we only set out to add filtering to WAR-level resources in EAR modules, and notably did NOT include filtering of the EAR-level application.xml in the design.

@scottkurz scottkurz changed the title Support for filters (Maven variables) & WAR overlays - PART 2: EAR modules Support for filters (Maven variables) & WAR overlays - PART 2: WAR-in-EAR modules Aug 9, 2023
@doteo78
Copy link

doteo78 commented Jun 14, 2024

Hi! I found this issue trying out the liberty-maven-plugin to run/debug our Java applications in Visual Code. These apps are multi-module EARs with WARs and JARs and we have the need to filter at least the web.xml file. Any chance this will be supported soon?

@scottkurz
Copy link
Member Author

scottkurz commented Jun 18, 2024

Hi! I found this issue trying out the liberty-maven-plugin to run/debug our Java applications in Visual Code. These apps are multi-module EARs with WARs and JARs and we have the need to filter at least the web.xml file. Any chance this will be supported soon?

Thanks for the question. No, I wouldn't expect this to be completed in the near term, but we will at least note your interest to prioritize. Completing the full support is not simple.

When I get the chance I'll try to see if there might be a workaround you might be able to issue "off to the side", i.e. manually, separately from the dev mode execution. In some cases that might be an option but it's not obvious to me whether it would in this case without looking more.

@scottkurz
Copy link
Member Author

@doteo78 I started a discussion here: #1817 about my workaround idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants