Replace WinForms crash dialog with SDL_ShowMessageBox. #18582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
commented
Sep 2, 2020
|
|
||
| namespace OpenRA | ||
| { | ||
| // Minimal SDL wrapper to work around SDL2-CS requiring netstandard2.0 |
There was a problem hiding this comment.
If we want to go ahead with this approach I will need to reword this to clearly attribute SDL2-CS and its license.
|
Another solution would to use https://avaloniaui.net/ |
|
As discussed on IRC, we'll do these changes in #17989 to avoid the uglyness of the SDL2-CS workaround. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve another issue facing #17989, that .net core refuses to build anything that uses winforms on non-windows platforms.
This will also resolve OpenRA/OpenRAModSDK#123 once the SDK is updated to use the newer engine.
Old dialog:
New dialog:
This includes a minimal wrapper that pinvokes directly into the sdl2.dll because I couldn't find any documentation on how to allow
cscto compile code that depends on netstandard that doesn't involve hardcoded filepaths. We should be able to replace this with SDL2-CS in #17989.Test builds: https://github.com/pchote/OpenRA/releases/tag/devtest-20200902