Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added verification for ostcomposer and redeempool contract #160

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Added verification for ostcomposer and redeempool contract #160

wants to merge 2 commits into from

Conversation

gulshanvasnani
Copy link
Contributor

PR contains changes to add ostcomposer and redeempool contract verification in mosaic verify command
fixes #129

@gulshanvasnani gulshanvasnani changed the title Added verifies for ostcomposer and redeempool contract Added verification for ostcomposer and redeempool contract Sep 30, 2019
puneet-khushwani-eth
puneet-khushwani-eth suggested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@puneet-khushwani-eth puneet-khushwani-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at this and personally wouldn't want to have two methods (one to verify contracts using bin mosaic.js and other using the ones from mosaic-contracts).

Instead would suggest that we come up with a proposal to handle contract versioning here.

@gulshanvasnani
Copy link
Contributor Author

gulshanvasnani commented Oct 11, 2019 •
edited
Loading

@puneet-khushwani-eth , create ticket describing approach to handle contract versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneet-khushwani-eth puneet-khushwani-eth puneet-khushwani-eth requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mosaic verify command should also verify RedeemPool and OSTComposer contract
2 participants
@gulshanvasnani @puneet-khushwani-eth