Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-block proposal should validate kernel #388

Open
0xsarvesh opened this issue Oct 18, 2018 · 1 comment
Open

Meta-block proposal should validate kernel #388

0xsarvesh opened this issue Oct 18, 2018 · 1 comment

Comments

@0xsarvesh
Copy link
Contributor

0xsarvesh commented Oct 18, 2018

User Story

As a core contract
I want to validate the kernel of a block proposal
Because I want to reject proposals for invalid kernels.

Scenario

Given that I have a valid kernel
When I propose the meta-block
Then the core contract should accept it.

Given that I have an invalid kernel
When I propose the meta-block
Then the core contract should reject it
And revert the transaction.

Info

Validation should be added to check for the validity of a kernel when a new meta-block is proposed.
The wrong kernel is also an invalid kernel. Proposals must be made for the currently open kernel.

The transition object has a kernel hash. That one must be the hash of the currently open kernel.

⚠️ The method MetaBlock.hashKernel() is just a placeholder and not yet implemented!

Contracts:

  • OriginCore
@schemar schemar changed the title Meta-block proposal should be accepted for valid kernel. Meta-block proposal should validate kernel Oct 18, 2018
@schemar schemar added the origin label Oct 18, 2018
@schemar
Copy link
Contributor

schemar commented Oct 22, 2018

Baby mosaic has a static set of validators. In worst case, use a zero validator delta in the kernel object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants