Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker repository name for nexus should be parameterized #8

Open
ribeaud opened this issue Feb 20, 2018 · 0 comments
Open

Docker repository name for nexus should be parameterized #8

ribeaud opened this issue Feb 20, 2018 · 0 comments

Comments

@ribeaud
Copy link

ribeaud commented Feb 20, 2018

Hi,
ImageStream definition looks as following (snippet):

...
spec:
    tags:
    - from:
        kind: DockerImage
        name: docker.io/sonatype/nexus3:${NEXUS_VERSION}
      name: ${NEXUS_VERSION}
...

docker.io/sonatype/nexus3 should be specified via a parameter as one might want to use its own image.

Another point to consider (applying to my case), it could happen that one already defined an ImageStream in the internal OpenShift Docker registry. And this is one which will be used by the deployment:

...
triggers:
    - type: ConfigChange
    - imageChangeParams:
        automatic: true
        containerNames:
        - ${SERVICE_NAME}
        from:
          kind: ImageStreamTag
          name: ${SERVICE_NAME}:${NEXUS_VERSION}
      type: ImageChange
...

How could this fit in with the template? In my case, I've removed the section ImageStream from the template.

What do you think?

Kind regards,

christian

@ribeaud ribeaud changed the title DockerImage should be a parameter as well Docker repository name for nexus should be parameterized Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant