Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p in a leads to broken link when converting to markdown #917

Closed
martinratinaud opened this issue Aug 30, 2022 · 5 comments · Fixed by OpenTermsArchive/turndown#1
Closed

p in a leads to broken link when converting to markdown #917

martinratinaud opened this issue Aug 30, 2022 · 5 comments · Fixed by OpenTermsArchive/turndown#1

Comments

@martinratinaud
Copy link
Member

martinratinaud commented Aug 30, 2022 •
edited
Loading

This might be the expected behavior and to be handle with a specific filter but I believe it's not

Example:

<ul>
<li><a href="#SCItemConditions2"><p>ARTICLE I. OBJET</p></a></li>
</ul>

leads to

[

ARTICLE I. OBJET

](#SCItemConditions2)

Here is an example on the contribution tool (Click on Verify Version)
@martinratinaud martinratinaud mentioned this issue Aug 30, 2022
Closed
6 tasks
@Ndpnt
Copy link
Member

Ndpnt commented Aug 31, 2022

Fixed in this PR mixmark-io/turndown#419

@martinratinaud
Copy link
Member Author

@Ndpnt this has been 6 days so I think we should proceed with our own fork.
Last commit was done 10 months ago

@Ndpnt Ndpnt mentioned this issue Sep 6, 2022
Merged
@martinratinaud
Copy link
Member Author

@Ndpnt where is the PR where you use this fork? I did not see it

@Ndpnt
Copy link
Member

Ndpnt commented Sep 6, 2022

@Ndpnt where is the PR where you use this fork? I did not see it

Not yet created

@Ndpnt Ndpnt reopened this Sep 6, 2022
Ndpnt added a commit that referenced this issue Sep 20, 2022
@Ndpnt
Update turndown
71c5a09 
Currently hosted on the @OpenTermsArchive account, until our PRs are
merged on the original repository

Fix:
- #917
- #903
@Ndpnt Ndpnt mentioned this issue Sep 20, 2022
Merged
Ndpnt added a commit that referenced this issue Sep 20, 2022
@Ndpnt
Update turndown
5a07f5f 
Currently hosted on the @OpenTermsArchive account, until our PRs are
merged on the original repository

Fix:
- #917
- #903
Ndpnt added a commit that referenced this issue Sep 20, 2022
@Ndpnt
Update turndown
f6929d1 
Currently hosted on the @OpenTermsArchive account, until our PRs are
merged on the original repository

Fix:
- #917
- #903
@MattiSG
Copy link
Member

MattiSG commented Apr 24, 2023

Duplicate of #903.

@MattiSG MattiSG closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix anchors containing block elements OpenTermsArchive/turndown
3 participants
@MattiSG @Ndpnt @martinratinaud