Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port - mk2 activities #43

Closed
JarbasAl opened this issue Feb 3, 2022 · 2 comments
Closed

port - mk2 activities #43

JarbasAl opened this issue Feb 3, 2022 · 2 comments
Labels
discussion do we want this? mk2 ported from mark2 mycroft-sync cherry pick from upstream

Comments

@JarbasAl
Copy link
Member

JarbasAl commented Feb 3, 2022 •
edited
Loading

new module https://github.com/MycroftAI/mycroft-core/tree/mark-ii/qa/mycroft/activity

mk2 activities https://github.com/MycroftAI/mycroft-core/tree/mark-ii/qa/mycroft/client/enclosure/mark2/activities

skill class activity util MycroftAI@a80c25e#diff-0d891356bfaa5c316f1565e9f4e3da6e193d8878c4a23bb1853c7c4f019c4581
@JarbasAl JarbasAl added mycroft-sync cherry pick from upstream mk2 ported from mark2 discussion do we want this? labels Feb 3, 2022
@NeonDaniel
Copy link
Member

Interesting concept... I like "activity" as a concept better than "state" since you might handle several activities with varying levels of overlap vs. a skill "state" that seemed to imply you are only ever in one "state"

@JarbasAl
Copy link
Member Author

now that dinkum is out I'm closing this one.

With #160 we can use the session_id + the existing self.add_event api to implement this as a generic util if wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion do we want this? mk2 ported from mark2 mycroft-sync cherry pick from upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JarbasAl @NeonDaniel