Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request - OCP options #96

Closed
JarbasAl opened this issue Jun 1, 2024 · 5 comments
Closed

request - OCP options #96

JarbasAl opened this issue Jun 1, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JarbasAl
Copy link
Member

JarbasAl commented Jun 1, 2024

i think OCP should be moved to an extra, like GUI and skills

if OCP is not installed mycroft.conf should also be updated

audio plugins are

i will assume "vlc" is used as the default, as it can handle more streams, but it could also be "simple"

{
    "enable_old_audioservice": true,
    "disable_ocp": true,
    "Audio": {
        "default-backend": "vlc"
   }
}

OCP should only be installed on setups with a GUI like the mk2 IMHO

voice satellites must use the config above, headless devices also recommended to use the above, but OCP will work there even without GUI

@JarbasAl
Copy link
Member Author

JarbasAl commented Jun 1, 2024

probably should wait for OpenVoiceOS/ovos-config#96 to be merged first

@goldyfruit
Copy link
Member

OCP has been added already ab7da15 but I might move it with the extra skills as this is required by TuneIn or Pyradios skills.

@goldyfruit goldyfruit self-assigned this Jun 2, 2024
@goldyfruit goldyfruit added the enhancement New feature or request label Jun 2, 2024
@goldyfruit goldyfruit added this to the Quake milestone Jun 2, 2024
@JarbasAl
Copy link
Member Author

JarbasAl commented Jun 2, 2024

OCP has been added already ab7da15 but I might move it with the extra skills as this is required by TuneIn or Pyradios skills.

i saw it, thats why i mentioned it, the companion config changes should also be done (if OCP is NOT installed)

note that the skills do not require OCP plugin at all, if the pipeline is enabled in config

@goldyfruit goldyfruit modified the milestones: Quake, Descent Jun 2, 2024
@goldyfruit
Copy link
Member

Then I will remove the plugin from this release as well as the TuneIn skill to the next `ovos-installer release. 👍

@goldyfruit
Copy link
Member

Since OpenVoiceOS/ovos-config#96 got merged I added back ovos-ocp-audio-plugin plugin.

@goldyfruit goldyfruit modified the milestones: Descent, Quake Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants