New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function flashLoan() could fail on some ethereum versions #12

Open

duzy opened this issue May 30, 2022 · 0 comments

duzy commented May 30, 2022 •

edited

Loading

The implementation

damn-vulnerable-defi/contracts/the-rewarder/FlashLoanerPool.sol

Lines 28 to 33 in 6797353

    
           (bool success, ) = msg.sender.call( 
        
               abi.encodeWithSignature( 
        
                   "receiveFlashLoan(uint256)", 
        
                   amount 
        
               ) 
        
           );

it is highly recommended to be replaced with this:

interface IFlashLoanReceiver {
    function receiveFlashLoan(uint256) external returns(bool);
}

and then

bool success = IFlashLoanReceiver(msg.sender).receiveFlashLoan(amount);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment