Default trigger names are bit strange

[quevon24]

Hi, i don't know if this is a bug or if the intention is for it to be like this, but if you don't set a custom label for InsertEvent, UpdateEvent or DeleteEvent, you will get some weird trigger names because the label and the operation have the same name, something like:

• pgtrigger_update_update_xxxxx
• pgtrigger_delete_delete_xxxxx
• pgtrigger_insert_insert_xxxxx

Maybe instead of generating the trigger name this way:

self.trigger_name = trigger_name or self.trigger_name or f"{self.label}_{self.operation}"

We can do something like:

self.trigger_name = trigger_name or self.trigger_name or f"{self.label}_{self.operation}" if self.label != self.operation else str(self.operation)

That way, if you don't pass a custom label you end up with something like:

• pgtrigger_update_xxxxx
• pgtrigger_delete_xxxxx
• pgtrigger_insert_xxxxx

[wesleykendall]

I remember seeing this as well a while ago, and I was hesitant to change it since it would result in many migrations being created. Some people that use pghistory for all models, for example, could have migrations generated for all of them at once.

so if it's changed, I think I'd:

• only enable the behavior via a setting
• Make it the default setting in an API break of a future version so that people aren't surprised by the new migrations

Hope that makes sense. I'm happy to tackle this as I agree that the naming is awkward

[quevon24]

I remember seeing this as well a while ago, and I was hesitant to change it since it would result in many migrations being created. Some people that use pghistory for all models, for example, could have migrations generated for all of them at once.

so if it's changed, I think I'd:

• only enable the behavior via a setting
• Make it the default setting in an API break of a future version so that people aren't surprised by the new migrations

Hope that makes sense. I'm happy to tackle this as I agree that the naming is awkward

That makes sense, thanks for replying so quickly