Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert users into started games #44

Open
SheepTester opened this issue Mar 4, 2020 · 4 comments
Open

Insert users into started games #44

SheepTester opened this issue Mar 4, 2020 · 4 comments
Labels
api Requires updating the server code enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@SheepTester
Copy link
Member

At least in the API end I suppose

@SheepTester SheepTester added enhancement New feature or request api Requires updating the server code labels Mar 4, 2020
@SheepTester
Copy link
Member Author

Also to revive people somehow...?

@SheepTester SheepTester added help wanted Extra attention is needed question Further information is requested labels Mar 5, 2020
@SheepTester
Copy link
Member Author

SheepTester commented Mar 5, 2020

To add players to games, either

  • Have people join normally. However, most games have joining turned on, so this would require some conversion process, which is complex on its own.

  • Have the game creator add them in manually. This requires more UI, and the settings page could get messy quickly. ADDENDUM: Also, this should require the player's consent.

After being added, their join date and username are added to a queue. When someone dies or a shuffle is performed, they can be pulled from the queue as needed.

  • Should the queue be shown to the game creator? If so, this requires more UI and API changes.

  • Should there be a way to remove people from the queue? Again, if so, this requires more UI.

Then to resurrect people, we need undo the kill by whoever just killed them. This is rather messy, but somewhat doable, especially since the individual stores whoever killed them, so we can decrement their kill count. I suppose we can just take their username and join time and add them to the queue.

However, this requires some more UI.

Also, might want to consider having the option to mark a kick as a kill, but this will result in code duplication.

@SheepTester
Copy link
Member Author

Maybe we should focus on just resurrecting players.

@SheepTester
Copy link
Member Author

There is no need for an eliminated person to be kicked, so I think the [Kick] button should be replaced with [Resurrect], which when clicked, it will without confirmation:

  • put the player username in an internal queue

  • send a notification to the player (note: since notifications can't be easily undone, that also means resurrecting can't be undone)

  • show player with new queue status

  • insert players from queue when assigning targets (either in death, or while shuffling; all players can be inserted at once in either scenario)

    • this should send a notification to the queued players that they now have targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Requires updating the server code enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant