Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let you choose which locale to use on the sandbox #2044

Open
thewilkybarkid opened this issue Oct 25, 2024 · 0 comments
Open

Let you choose which locale to use on the sandbox #2044

thewilkybarkid opened this issue Oct 25, 2024 · 0 comments

Comments

@thewilkybarkid
Copy link
Member

No description provided.

thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Add a seam for setting the locale via a cookie
dd9f3af 
Refs #2044
erkannt added a commit that referenced this issue Oct 25, 2024
@erkannt
Create space for reading a cookie
75a5384 
Refs: #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Set the locale based on a cookie
7a667ad 
This change sets the locale for the request based on a cookie. There's no way to set the cookie through the UI, and the only valid option is the DefaultLocale anyhow so it's safe to include without a feature flag.

Refs #2044
erkannt added a commit that referenced this issue Oct 25, 2024
@erkannt
Prepare to pass request specific locale to pages in the express router
42be6ee 
Refs: #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Pass the locale through to Express pages
736373f 
This change avoids duplicating reading the cookie on the legacy pages by passing through the already-read value. This requires a change to our Express usage to allow for request-specific arguments. As we're not using Express to listen for requests, we've favoured this type-safe way (as opposed to Express's standard of modifying the request object).

Refs #2044
erkannt added a commit that referenced this issue Oct 25, 2024
@erkannt
Remove some hardcoded locales
3ad0378 
Refs: #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Hardcode a non-functioning language picker
224eb36 
This is never accessible as it's behind a feature flag, and doesn't work either.

Refs #2044
erkannt added a commit that referenced this issue Oct 25, 2024
@erkannt
Push up hardcoding of feature flag
108ca66 
Refs: #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Allow enabling the language picker with an environment variable
85a4227 
Note this only works on Express pages, not Effect pages.

Refs #2044
erkannt added a commit that referenced this issue Oct 25, 2024
@erkannt
Get ready to support a second locale
915a8f5 
Ensure locale cookie only is used when feature flag is enabled.

Refs: #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Create a stub web component for the locale picker
b0f9f5c 
Refs #2044
erkannt added a commit that referenced this issue Oct 25, 2024
@erkannt
Remove stray }
38244b3 
Refs: #2044, b0f9f5c
erkannt added a commit that referenced this issue Oct 25, 2024
@erkannt
Make the locale picker functional
b31a70d 
This is limited to supported locales which currently only is 'en-US'.

Refs: #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Use the same cookie across the whole site
c82b6e9 
Refs #2044, b31a70d
erkannt added a commit that referenced this issue Oct 25, 2024
@erkannt
Make latin american spanish available as a supported locale
74472b1 
Currently only one strings is translated, the main CTA on the homepage.

Refs: #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Let us try locale-picking on the sandbox
bb9ba70 
Refs #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Stop the link from being followed
e1d97b9 
Refs #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Remove hardcoding from the page-level locale
a77936a 
Refs #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Show supported locales in their own language
e89c7ae 
Refs #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Reduce the size of locale names
6b482d5 
Refs #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Make the locale picker fit a bit better
59c1f77 
Refs #2044
thewilkybarkid added a commit that referenced this issue Oct 25, 2024
@thewilkybarkid
Show the current locale
426c38d 
Refs #2044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewilkybarkid