Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw errors on republish #528

Open
cavis opened this issue Aug 26, 2019 · 0 comments
Open

Don't throw errors on republish #528

cavis opened this issue Aug 26, 2019 · 0 comments
Assignees
@cavis
Labels
medium

Comments

@cavis
Copy link
Member

cavis commented Aug 26, 2019

Currently when an episode is already published, and you POST publish again, you get an error. Same with double-unpublishing.

Story 288986 is already published

This is a bit annoying for the frontend, which may be out-of-sync with the backend. We should:

  • Not throw 500s (maybe a 4xx? or would a 200 be fine?), and not log to new relic
  • Make sure the Publish frontend can handle it
@cavis cavis self-assigned this Sep 9, 2019
@cavis cavis added this to the Sprint Query milestone Sep 9, 2019
@cavis cavis added the medium label Sep 9, 2019
@cavis cavis modified the milestones: Sprint Query, Sprint Ryan Sep 17, 2019
@cavis cavis modified the milestones: Sprint Ryan, Sprint StJean Oct 8, 2019
@cavis cavis modified the milestones: Sprint StJean, Sprint Twiss Oct 15, 2019
@cavis cavis modified the milestones: Sprint Twiss, Sprint Uzair Oct 29, 2019
@cavis cavis modified the milestones: Sprint Uzair, Sprint Valdo Nov 12, 2019
@cavis cavis removed this from the Sprint Xanadu milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cavis cavis

Labels
medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cavis