Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Dronecan Firmware Updating is Broken on Main #23727

Open
AlexKlimaj opened this issue Sep 25, 2024 · 4 comments · May be fixed by #23819
Open

[Bug] Dronecan Firmware Updating is Broken on Main #23727

AlexKlimaj opened this issue Sep 25, 2024 · 4 comments · May be fixed by #23819
Assignees
@julianoes
Labels
bug-report

Comments

@AlexKlimaj
Copy link
Member

Describe the bug

Firmware updating on 1.15 works but is broken on main after the Dronecan submodule update. Nodes fail the update then the update restarts and fails again indefinitely.

Online nodes (Node ID, Health, Mode):
         71 CRIT       SW_UPD

uavcan: cycle time: 71419 events, 4965837us elapsed, 69.53us avg, min 10us max 72605us 488.892us rms
uavcan: cycle interval: 71419 events, 2893.50us avg, min 19us max 266795us 2696.179us rms
nsh> INFO  [uavcan:71:Boot] Es
ERROR [uavcan:71:Boot] Pf
INFO  [uavcan:71:Boot] Es
ERROR [uavcan:71:Boot] Pf
INFO  [uavcan:71:Boot] Es

To Reproduce

No response

Expected behavior

No response

Screenshot / Media

No response

Flight Log

No response

Software Version

No response

Flight controller

No response

Vehicle type

None

How are the different components wired up (including port information)

No response

Additional context

No response
@dakejahl dakejahl mentioned this issue Sep 25, 2024
Merged
@julianoes
Copy link
Contributor

This is updating via the PX4 SD card? I wasn't aware of that method and always used the gui tool with a USB to CAN tool.

@AlexKlimaj
Copy link
Member Author

The main way I've always been updating firmware over CAN has been from the PX4 SD card. Most customers use this method as well since not many people have USB to CAN adapters.

@julianoes
Copy link
Contributor

Makes sense. I will have to test this and fix it.

@julianoes julianoes self-assigned this Oct 9, 2024
@DronecodeBot
Copy link

This issue has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-oct-09-2024/41789/1

dagar added a commit that referenced this issue Oct 16, 2024
@dagar
drivers/uavcan: subtree merge last working libuavcan (preserving hist…
d85ab9e 
…ory)

 - upstream libuavcan was broken and then marked deprecated, this fully absorbs the submodule (renamed libdronecan to deconflict) up to our last good working commit and all commit history is kept
 - fixes #23727 (regression introduced in #23113)
 - this puts us in a much better position to evolve the library as needed now that we have full control
@dagar dagar linked a pull request Oct 16, 2024 that will close this issue
Open
dagar added a commit that referenced this issue Oct 16, 2024
@dagar
drivers/uavcan: subtree merge last working libuavcan (preserving hist…
e59cc9a 
…ory)

 - upstream libuavcan was broken and then marked deprecated, this fully absorbs the submodule (renamed libdronecan to deconflict) up to our last good working commit and all commit history is kept
 - fixes #23727 (regression introduced in #23113)
 - this puts us in a much better position to evolve the library as needed now that we have full control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianoes julianoes

Labels
bug-report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drivers/uavcan: subtree merge last working libuavcan (preserving history) PX4/PX4-Autopilot
3 participants
@julianoes @AlexKlimaj @DronecodeBot