Improvements to PotionType + PotionData

[Owen1212055]

Currently retrieving potion effects is quite limiting and a hassle to deal with. It seems like what is currently in place does not support the modern-day potions that we have. For example, there are potion types that now can contain multiple effects. (See, turtle master potion)

It is also not very easy to get the duration/amplifier of potions without dealing with "extended" and "upgraded".

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like

• An easy way to get List<PotionEffect> from PotionData. This would take into account extended + upgraded and give the corresponding effects. So potions like turtle master would return two effects.
• Adding support for multiple potion effect types from PotionType. Currently certain potions can have multiple effects on them by default, for example the turtle master potion. The system currently in place does not support this, as it only displays the slowness effect instead.
  

Describe alternatives you've considered
There really aren't any very easy alternatives that work nicely. You would need to store all of this yourself, so instead, I just use NMS to deal with this. However, it would be great if this could be officially supported because I feel that others may benefit from this as well.

Additional context
N/A

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Owen1212055]

I cast you away, silly stale bot.

[electronicboy]

https://www.youtube.com/watch?v=ib084tzN8H0

[electronicboy]

This API has pretty much always been cludgy to work with and could probs just do with a replacement drafting for the API here as a whole rather than trying to expand it, maybe

[Machine-Maker]

PotionType and PotionData have been merged together. This should solve this issue.