-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ProjectileHitEvent not called for multiple HitResults #10804
base: master
Are you sure you want to change the base?
Fix ProjectileHitEvent not called for multiple HitResults #10804
Conversation
just one thing when you guys decide to test the pr. arrows just disappearing client side when the event is cancelled is also an issue without the patch but i am not sure wether or not that is fixable |
f9943bb
to
66ad7db
Compare
So right now this probably has issues with the piercing enchantment (haven't tested but is very likely). before i however resolve that i would like to know what design we will be going forwards with. Lynx suggested instead of adding new methods to ProjectileUtil which return all entities in the range, we should do something similar to piercingIngoreEntityIds. I have tried to implement this for 1 or 2 of the Projectile Classes however i noticed that the diff is often even bigger/ just as big as before, we also have to clip entites more often with his implementation. |
66ad7db
to
3819af6
Compare
Todo: look at removing piercingEntityIds since that seems to be in use somewhere else (too lazy rn) and retitle pr/patch |
patches/server/1065-Fix-ProjectileHitEvent-not-calling-for-multiple-enti.patch
Outdated
Show resolved
Hide resolved
3819af6
to
0bdc5b5
Compare
Will get around to fully testing it later, for now it compiles and starts. |
ad46dce
to
a878e46
Compare
patches/server/1066-Fix-ProjectileHitEvent-not-called-for-multiple-HitRe.patch
Outdated
Show resolved
Hide resolved
a878e46
to
28ca2a7
Compare
fixes #10801
Download the paperclip jar for this pull request: paper-10804.zip