Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProjectileHitEvent not called for multiple HitResults #10804

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

notTamion
Copy link
Contributor

@notTamion notTamion commented May 28, 2024

fixes #10801


Download the paperclip jar for this pull request: paper-10804.zip

@notTamion notTamion requested a review from a team as a code owner May 28, 2024 12:32
@notTamion
Copy link
Contributor Author

just one thing when you guys decide to test the pr. arrows just disappearing client side when the event is cancelled is also an issue without the patch but i am not sure wether or not that is fixable

@notTamion notTamion force-pushed the fix-projectilehitevent-not-called branch from f9943bb to 66ad7db Compare July 13, 2024 19:09
@notTamion
Copy link
Contributor Author

So right now this probably has issues with the piercing enchantment (haven't tested but is very likely). before i however resolve that i would like to know what design we will be going forwards with. Lynx suggested instead of adding new methods to ProjectileUtil which return all entities in the range, we should do something similar to piercingIngoreEntityIds. I have tried to implement this for 1 or 2 of the Projectile Classes however i noticed that the diff is often even bigger/ just as big as before, we also have to clip entites more often with his implementation.

@notTamion
Copy link
Contributor Author

notTamion commented Oct 14, 2024

Todo: look at removing piercingEntityIds since that seems to be in use somewhere else (too lazy rn) and retitle pr/patch

@lynxplay lynxplay added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Oct 14, 2024
@notTamion notTamion force-pushed the fix-projectilehitevent-not-called branch from 3819af6 to 0bdc5b5 Compare October 14, 2024 15:36
@notTamion
Copy link
Contributor Author

notTamion commented Oct 14, 2024

Will get around to fully testing it later, for now it compiles and starts.

@notTamion notTamion changed the title Fix ProjectileHitEvent not called multiple entities Fix ProjectileHitEvent not called for multiple HitResults Oct 14, 2024
@notTamion notTamion force-pushed the fix-projectilehitevent-not-called branch 2 times, most recently from ad46dce to a878e46 Compare October 15, 2024 12:39
@notTamion notTamion force-pushed the fix-projectilehitevent-not-called branch from a878e46 to 28ca2a7 Compare October 20, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request.
Projects
Status: Awaiting review
3 participants