Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow running importMcDev without applyPatches (to not interrupt) #13

Open
MiniDigger opened this issue Jun 14, 2021 · 1 comment
Open
Labels
hopefully We want to do this, but it may not be likely type: feature New feature or request

Comments

@MiniDigger
Copy link
Member

tried it here https://github.com/PaperMC/paperweight/tree/feature/importmcdev
obviously doesn't work, because the files will not be added to git at the right spot.
maybe we wanna automate stashing and then do a fixup commit and rebase?

@MiniDigger MiniDigger added the type: feature New feature or request label Jun 14, 2021
@DenWav
Copy link
Member

DenWav commented Jun 16, 2021

This is likely not to be possible / too difficult due to the fact that this has to modify the base patch to add the file (which means patches have to be applied and re-built). If someone can figure out a way to do this that won't blow away changes (which would include cases where someone's in the middle of an interactive rebase and editing a commit in the middle of the history) then that would be cool.

@DenWav DenWav added the hopefully We want to do this, but it may not be likely label Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hopefully We want to do this, but it may not be likely type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants