Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Errors in Languages interface #27

Open
AdrienSeon opened this issue Mar 15, 2021 · 0 comments
Open

[Bug] Errors in Languages interface #27

AdrienSeon opened this issue Mar 15, 2021 · 0 comments

Comments

@AdrienSeon
Copy link

AdrienSeon commented Mar 15, 2021

It seems there are some errors in the Languages interface for the following constants:

  • CHINESE
  • CHINESE_HONGKONG
  • ISRAELI
  • MEXICAN

Some other mentions:

  • INDIAN should be HINDI
  • Brazilian doesn't exist, its Portuguese
  • Mexican doesn't exist, its Spanish
  • Malay doesn't exist, if it was intended for Malaysia, it's English
  • For Iran it should be PERSIAN with "fa"
  • For Philippine it should be FILIPINO and there's only ISO 939-2 three-letter code "fil"
  • ISRAELI is not a valid ISO 939-1 code, it should be Hebrew with "he"

And if we want to be accurate with ISO 939-1 two-letter codes (don't know how it's used app side) here are some other adjustments:

  • Chinese is not really accurate for ISO 939-1 but might be OK depending on how it's used app side
  • For Czech it should be "cs" conforming to ISO 939-1
  • Danish should be "da" conforming to ISO 939-1
  • Welsh should be "cy" conforming to ISO 939-1
  • Greek should be "el" conforming to ISO 939-1
  • CHINEESE_HONGKONG = 'hk' is not a valid ISO 939-1 code
  • Japanese should be "ja" conforming to ISO 939-1
  • Korean should be "ko" conforming to ISO 939-1
  • SAMI = 'si' isn't a valid ISO 939-1 code, there is ISO 939-2 code "smi" though. There is Northern Sami with "se" which is the most widely spoken of all Sami languages.
  • Ukrainian should be "uk" conforming to ISO 939-1
  • Vietnamese should be "vi"
  • English should be "en" conforming to ISO 939-1

ISO 939-1 wiki link for reference

@AdrienSeon AdrienSeon changed the title [Bug] Spelling errors in Languages interface [Bug] Errors in Languages interface Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant